[PATCH] D22630: Loop rotation

Michael Kruse via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 21 10:17:30 PDT 2016


Meinersbur added a subscriber: Meinersbur.

================
Comment at: llvm/include/llvm/Transforms/Utils/Cloning.h:238-239
@@ +237,4 @@
+/// and post-dominated by \p Exit.
+bool isSESE(const BasicBlock *Entry, const BasicBlock *Exit, DominatorTree *DT,
+            DominatorTree *PDT);
+
----------------
I don't see any use of `isSESE()`. What is it good for?

================
Comment at: llvm/lib/Transforms/Scalar/LoopRotation.cpp:676
@@ -675,3 @@
-    auto *SE = SEWP ? &SEWP->getSE() : nullptr;
-    LoopRotate LR(MaxHeaderSize, LI, TTI, AC, DT, SE);
-    return LR.processLoop(L);
----------------
Doesn't ScalarEvolution need be updated anymore? `getLoopAnalysisUsage()` adds `SCEVAAWrapperPass` (but not `ScalarEvolution` itself?)


https://reviews.llvm.org/D22630





More information about the llvm-commits mailing list