[compiler-rt] r276290 - [compiler-rt] Disable some unittests on windows that rely on shell command

Etienne Bergeron via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 21 07:55:18 PDT 2016


Author: etienneb
Date: Thu Jul 21 09:55:17 2016
New Revision: 276290

URL: http://llvm.org/viewvc/llvm-project?rev=276290&view=rev
Log:
[compiler-rt] Disable some unittests on windows that rely on shell command

Summary:
These unittests are not running on windows because they are using incorrect commands.
They were not failing on 32-bits because there is a requirement: asan-64-bits.

```
$ "nm" "C:\src\llvm\ninja64\projects\compiler-rt\test\asan\X86_64WindowsConfig\TestCases\Output\no_asan_gen_globals.c.tmp.exe"
# command stderr:
'nm': command not found
error: command failed with exit status: 127
```

```
$ "rm" "-rf" "C:\src\llvm\ninja64\projects\compiler-rt\test\asan\X86_64WindowsConfig\TestCases\Output/coverage-tracing"
$ "mkdir" "C:\src\llvm\ninja64\projects\compiler-rt\test\asan\X86_64WindowsConfig\TestCases\Output/coverage-tracing"
$ "A=x"
# command stderr:
'A=x': command not found
error: command failed with exit status: 127
```


```
$ "DIR=C:\src\llvm\ninja64\projects\compiler-rt\test\asan\X86_64WindowsConfig\TestCases\Output/coverage-order-pcs"
# command stderr:
'DIR=C:\\src\\llvm\\ninja64\\projects\\compiler-rt\\test\\asan\\X86_64WindowsConfig\\TestCases\\Output/coverage-order-pcs': command not found
error: command failed with exit status: 127
```

Reviewers: rnk

Subscribers: tberghammer, llvm-commits, danalbert, wang0109, srhines, kubabrecka, chrisha

Differential Revision: https://reviews.llvm.org/D22612

Added:
    compiler-rt/trunk/test/asan/TestCases/Posix/no_asan_gen_globals.c
      - copied, changed from r276282, compiler-rt/trunk/test/asan/TestCases/no_asan_gen_globals.c
Removed:
    compiler-rt/trunk/test/asan/TestCases/no_asan_gen_globals.c
Modified:
    compiler-rt/trunk/test/asan/TestCases/coverage-order-pcs.cc
    compiler-rt/trunk/test/asan/TestCases/coverage-tracing.cc
    compiler-rt/trunk/test/asan/TestCases/intra-object-overflow.cc

Copied: compiler-rt/trunk/test/asan/TestCases/Posix/no_asan_gen_globals.c (from r276282, compiler-rt/trunk/test/asan/TestCases/no_asan_gen_globals.c)
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/asan/TestCases/Posix/no_asan_gen_globals.c?p2=compiler-rt/trunk/test/asan/TestCases/Posix/no_asan_gen_globals.c&p1=compiler-rt/trunk/test/asan/TestCases/no_asan_gen_globals.c&r1=276282&r2=276290&rev=276290&view=diff
==============================================================================
--- compiler-rt/trunk/test/asan/TestCases/no_asan_gen_globals.c (original)
+++ compiler-rt/trunk/test/asan/TestCases/Posix/no_asan_gen_globals.c Thu Jul 21 09:55:17 2016
@@ -2,7 +2,6 @@
 // XFAIL: android
 // FIXME: http://llvm.org/bugs/show_bug.cgi?id=22682
 // REQUIRES: asan-64-bits
-//
 // Make sure __asan_gen_* strings do not end up in the symbol table.
 
 // RUN: %clang_asan %s -o %t.exe

Modified: compiler-rt/trunk/test/asan/TestCases/coverage-order-pcs.cc
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/asan/TestCases/coverage-order-pcs.cc?rev=276290&r1=276289&r2=276290&view=diff
==============================================================================
--- compiler-rt/trunk/test/asan/TestCases/coverage-order-pcs.cc (original)
+++ compiler-rt/trunk/test/asan/TestCases/coverage-order-pcs.cc Thu Jul 21 09:55:17 2016
@@ -19,7 +19,7 @@
 //
 // RUN: rm -rf $DIR
 // Ordering works only in 64-bit mode for now.
-// REQUIRES: asan-64-bits
+// REQUIRES: asan-64-bits, shell
 // UNSUPPORTED: android
 #include <stdio.h>
 

Modified: compiler-rt/trunk/test/asan/TestCases/coverage-tracing.cc
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/asan/TestCases/coverage-tracing.cc?rev=276290&r1=276289&r2=276290&view=diff
==============================================================================
--- compiler-rt/trunk/test/asan/TestCases/coverage-tracing.cc (original)
+++ compiler-rt/trunk/test/asan/TestCases/coverage-tracing.cc Thu Jul 21 09:55:17 2016
@@ -24,7 +24,7 @@
 // RUN: not diff b.points bf.points
 // RUN: rm -rf   %T/coverage-tracing
 //
-// REQUIRES: asan-64-bits
+// REQUIRES: asan-64-bits, shell
 // UNSUPPORTED: android
 
 #include <stdlib.h>

Modified: compiler-rt/trunk/test/asan/TestCases/intra-object-overflow.cc
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/asan/TestCases/intra-object-overflow.cc?rev=276290&r1=276289&r2=276290&view=diff
==============================================================================
--- compiler-rt/trunk/test/asan/TestCases/intra-object-overflow.cc (original)
+++ compiler-rt/trunk/test/asan/TestCases/intra-object-overflow.cc Thu Jul 21 09:55:17 2016
@@ -4,6 +4,8 @@
 //
 // FIXME: fix 32-bits.
 // REQUIRES: asan-64-bits
+// FIXME: Implement ASan intra-object padding in Clang's MS record layout
+// UNSUPPORTED: win32
 #include <stdio.h>
 #include <stdlib.h>
 class Foo {

Removed: compiler-rt/trunk/test/asan/TestCases/no_asan_gen_globals.c
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/asan/TestCases/no_asan_gen_globals.c?rev=276289&view=auto
==============================================================================
--- compiler-rt/trunk/test/asan/TestCases/no_asan_gen_globals.c (original)
+++ compiler-rt/trunk/test/asan/TestCases/no_asan_gen_globals.c (removed)
@@ -1,13 +0,0 @@
-// FIXME: https://code.google.com/p/address-sanitizer/issues/detail?id=316
-// XFAIL: android
-// FIXME: http://llvm.org/bugs/show_bug.cgi?id=22682
-// REQUIRES: asan-64-bits
-//
-// Make sure __asan_gen_* strings do not end up in the symbol table.
-
-// RUN: %clang_asan %s -o %t.exe
-// RUN: nm %t.exe | FileCheck %s
-
-int x, y, z;
-int main() { return 0; }
-// CHECK-NOT: __asan_gen_




More information about the llvm-commits mailing list