[PATCH] D22612: [compiler-rt] Disable some unittests on windows that rely on shell command

Etienne Bergeron via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 21 07:55:07 PDT 2016


etienneb updated this revision to Diff 64892.
etienneb marked 2 inline comments as done.
etienneb added a comment.

rnk comments


https://reviews.llvm.org/D22612

Files:
  test/asan/TestCases/Posix/no_asan_gen_globals.c
  test/asan/TestCases/coverage-order-pcs.cc
  test/asan/TestCases/coverage-tracing.cc
  test/asan/TestCases/no_asan_gen_globals.c

Index: test/asan/TestCases/no_asan_gen_globals.c
===================================================================
--- test/asan/TestCases/no_asan_gen_globals.c
+++ test/asan/TestCases/no_asan_gen_globals.c
@@ -1,13 +0,0 @@
-// FIXME: https://code.google.com/p/address-sanitizer/issues/detail?id=316
-// XFAIL: android
-// FIXME: http://llvm.org/bugs/show_bug.cgi?id=22682
-// REQUIRES: asan-64-bits
-//
-// Make sure __asan_gen_* strings do not end up in the symbol table.
-
-// RUN: %clang_asan %s -o %t.exe
-// RUN: nm %t.exe | FileCheck %s
-
-int x, y, z;
-int main() { return 0; }
-// CHECK-NOT: __asan_gen_
Index: test/asan/TestCases/coverage-tracing.cc
===================================================================
--- test/asan/TestCases/coverage-tracing.cc
+++ test/asan/TestCases/coverage-tracing.cc
@@ -24,7 +24,7 @@
 // RUN: not diff b.points bf.points
 // RUN: rm -rf   %T/coverage-tracing
 //
-// REQUIRES: asan-64-bits
+// REQUIRES: asan-64-bits, shell
 // UNSUPPORTED: android
 
 #include <stdlib.h>
Index: test/asan/TestCases/coverage-order-pcs.cc
===================================================================
--- test/asan/TestCases/coverage-order-pcs.cc
+++ test/asan/TestCases/coverage-order-pcs.cc
@@ -19,7 +19,7 @@
 //
 // RUN: rm -rf $DIR
 // Ordering works only in 64-bit mode for now.
-// REQUIRES: asan-64-bits
+// REQUIRES: asan-64-bits, shell
 // UNSUPPORTED: android
 #include <stdio.h>
 
Index: test/asan/TestCases/Posix/no_asan_gen_globals.c
===================================================================
--- test/asan/TestCases/Posix/no_asan_gen_globals.c
+++ test/asan/TestCases/Posix/no_asan_gen_globals.c
@@ -2,7 +2,6 @@
 // XFAIL: android
 // FIXME: http://llvm.org/bugs/show_bug.cgi?id=22682
 // REQUIRES: asan-64-bits
-//
 // Make sure __asan_gen_* strings do not end up in the symbol table.
 
 // RUN: %clang_asan %s -o %t.exe


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D22612.64892.patch
Type: text/x-patch
Size: 1885 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160721/19406801/attachment.bin>


More information about the llvm-commits mailing list