[PATCH] D22519: Invariant start/end intrinsics overloaded for address space

[Artur Pilipenko via llvm-commits]

apilipenko added a comment.

Please add a test case for autoupgrade functionality. See auto_upgrade_intrinsics.ll for examples.


================
Comment at: docs/LangRef.rst:11845
@@ -11844,2 +11844,3 @@
 """""""
+This is an overloaded intrinsic. The memory object can belong to any address space.
 
----------------
I'd omit this for the sake of consistency with other intrinsics.

================
Comment at: lib/IR/AutoUpgrade.cpp:155
@@ +154,3 @@
+      if (F->getName() !=
+          Intrinsic::getName(Intrinsic::invariant_start, Args[1])) {
+        F->setName(Name + ".old");
----------------
I'd extract locals for Arg[1] and Arg[2]. The name of these variables will make it clear what the overloaded types are for. 


Repository:
  rL LLVM

https://reviews.llvm.org/D22519