[PATCH] D22627: Fix PR28575

[Rui Ueyama via llvm-commits]

ruiu added inline comments.

================
Comment at: ELF/MarkLive.cpp:115
@@ +114,3 @@
+static void scanEhFrameSection(EhInputSection<ELFT> &EH, ArrayRef<RelTy> Rels,
+                               std::function<void(ResolvedReloc<ELFT>)> Fn) {
+  const endianness E = ELFT::TargetEndianness;
----------------
I'd rename Fn Enqueue.

================
Comment at: ELF/OutputSections.cpp:1032
@@ -1049,3 +1031,3 @@
     if (ID == 0) {
-      OffsetToCie[Offset] = addCie(Piece, Sec, Rels);
+      OffsetToCie[Offset] = addCie(Piece, FirstRelI, Sec, Rels);
       continue;
----------------
You don't need to pas `FirstRelI` as a separate parameter because you can use Piece->FirstRelocation instead.

================
Comment at: ELF/OutputSections.cpp:1041
@@ -1058,3 +1040,3 @@
 
-    if (!isFdeLive(Piece, Sec, Rels))
+    if (!isFdeLive(Piece, FirstRelI, Sec, Rels))
       continue;
----------------
Ditto.


https://reviews.llvm.org/D22627