[PATCH] D22617: [ELF] - Linkerscript: add InputSectionDescription command to LS parser.

[George Rimar via llvm-commits]

grimar added inline comments.

================
Comment at: ELF/LinkerScript.cpp:266
@@ -245,2 +265,3 @@
+  }
 
   // Add all other input sections, which are not listed in script.
----------------
ruiu wrote:
> grimar wrote:
> > Afraid I am a bit lost in this puzzle :)
> > Is that what you mean ?
> > 
> > ```
> > static bool match(StringRef T, ArrayRef<StringRef> Pattern) {
> >   for (StringRef S : Pattern)
> >     if (globMatch(S, T))
> >       return true;
> >   return false;
> > }
> > ```
> 1. I want parameters of similar functions be ordered in a consistent way. However, your new function takes [Pattern Target] although globMatch takes [Target Pattern]
> 2. T is too short and doesn't convey it is a glob pattern rather.
> 3. Apparently Pattern is not a right name for ArrayRef<StringRef> that doesn't contain patterns
> 
>   static bool match(StringRef Pattern, ArrayRef<StringRef> Arr) {
>     for (StringRef S : Arr)
>       if (globMatch(Pattern, S))
>         return true;
>     return false;
>   }
Ok, now I see what you meant. Sorry for my confusion and thanks a lot for all reviews !


https://reviews.llvm.org/D22617