[PATCH] D22625: [ELF] Support PROVIDE and PROVIDE_HIDDEN within SECTIONS {} block

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 21 06:57:09 PDT 2016


ruiu added a comment.

I believe there's a better way, but it's probably too detailed and doesn't have to be done in this patch. But at least can you separate add a separate flag to record whether a symbol was present or not, so that we don't mutate parse results in an obscure way?

Also I believe you want to define two boolean members, Provide and Hidden, instead of one member that has a combination of the two variables.


Repository:
  rL LLVM

https://reviews.llvm.org/D22625





More information about the llvm-commits mailing list