[PATCH] D22625: [ELF] Support PROVIDE and PROVIDE_HIDDEN within SECTIONS {} block

[Rui Ueyama via llvm-commits]

ruiu added inline comments.

================
Comment at: ELF/LinkerScript.cpp:459
@@ +458,3 @@
+        else if (Cmd->Provision != SymbolProvision::Create)
+          Cmd->Provision = SymbolProvision::Ignore;
+      }
----------------
evgeny777 wrote:
> ruiu wrote:
> > This doesn't look beautiful. Isn't there any better way?
> I need some flag, so that I don't override value of provided symbol later in assignAddresses, in case it is already defined somewhere. I'll think how to rewrite it, and open to suggestions.
How about adding a SymbolBody* to SymbolAssignment class and set it to the return value of addAbsolute?


Repository:
  rL LLVM

https://reviews.llvm.org/D22625