[compiler-rt] r276256 - Attempt to fix clang-cmake-mips after r268977.

[Daniel Sanders via llvm-commits]

Hi Chris,

Vasileios and I rebooted one of our buildslaves yesterday to fix some disk errors and when we brought it back up we found that compiler-rt is failing some mips64 tests. However, these tests weren't enabled before. I think it has wiped out the build area and fully-reconfigured and this has caused it to notice the changes in r268977 and set CAN_TARGET_mips64=TRUE. It used to be false because it's the linker cannot find the multilibs (they're not installed).

This attempt at fixing it didn't work so I've already reverted it and manually set CAN_TARGET_mips64=FALSE instead. This should get us back to the position we were in before the reboot but it will only last until the next time it fully reconfigures.

Do you have any suggestions for fixing this properly?

> -----Original Message-----
> From: llvm-commits [mailto:llvm-commits-bounces at lists.llvm.org] On Behalf
> Of Daniel Sanders via llvm-commits
> Sent: 21 July 2016 10:28
> To: llvm-commits at lists.llvm.org
> Subject: [compiler-rt] r276256 - Attempt to fix clang-cmake-mips after
> r268977.
> 
> Author: dsanders
> Date: Thu Jul 21 04:28:09 2016
> New Revision: 276256
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=276256&view=rev
> Log:
> Attempt to fix clang-cmake-mips after r268977.
> 
> I think it's wiped out the build area and fully-reconfigured for the first time
> since r268977. This seems to have caused Mips64 to become enabled when it
> wasn't
> before because compiling with -mabi=64 succeeds but linking with -mabi=64
> fails.
> 
> 
> Modified:
>     compiler-rt/trunk/cmake/builtin-config-ix.cmake
> 
> Modified: compiler-rt/trunk/cmake/builtin-config-ix.cmake
> URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/cmake/builtin-
> config-ix.cmake?rev=276256&r1=276255&r2=276256&view=diff
> ==========================================================
> ====================
> --- compiler-rt/trunk/cmake/builtin-config-ix.cmake (original)
> +++ compiler-rt/trunk/cmake/builtin-config-ix.cmake Thu Jul 21 04:28:09
> 2016
> @@ -2,6 +2,12 @@ include(BuiltinTests)
> 
>  # Make all the tests only check the compiler
>  set(TEST_COMPILE_ONLY On)
> +# Temporary fix for Mips buildbots this broke. It's the linker that rejects
> +# inappropriate multilibs on this system.
> +check_compile_definition("__mips__" "" IS_MIPS_HOST)
> +if(IS_MIPS_HOST)
> +  set(TEST_COMPILE_ONLY OFF)
> +endif()
> 
>  builtin_check_c_compiler_flag(-fPIC
> COMPILER_RT_HAS_FPIC_FLAG)
>  builtin_check_c_compiler_flag(-fPIE
> COMPILER_RT_HAS_FPIE_FLAG)
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits