[PATCH] D22615: [ELF] - Linkerscript: remove excessive ScriptConfiguration::Filler field

[George Rimar via llvm-commits]

grimar created this revision.
grimar added reviewers: ruiu, rafael.
grimar added subscribers: llvm-commits, grimar, evgeny777.

Previously OutputSectionCommand::Filler was introduced, but unused.
Patch fixes that.

https://reviews.llvm.org/D22615

Files:
  LinkerScript.cpp
  LinkerScript.h

Index: LinkerScript.h
===================================================================
--- LinkerScript.h
+++ LinkerScript.h
@@ -86,9 +86,6 @@
   // SECTIONS commands.
   std::vector<SectionRule> Sections;
 
-  // Section fill attribute for each section.
-  llvm::StringMap<std::vector<uint8_t>> Filler;
-
   // Used to assign addresses to sections.
   std::vector<std::unique_ptr<BaseCommand>> Commands;
 
Index: LinkerScript.cpp
===================================================================
--- LinkerScript.cpp
+++ LinkerScript.cpp
@@ -410,10 +410,11 @@
 
 template <class ELFT>
 ArrayRef<uint8_t> LinkerScript<ELFT>::getFiller(StringRef Name) {
-  auto I = Opt.Filler.find(Name);
-  if (I == Opt.Filler.end())
-    return {};
-  return I->second;
+  for (const std::unique_ptr<BaseCommand> &Base : Opt.Commands)
+    if (auto *Cmd = dyn_cast<OutputSectionCommand>(Base.get()))
+      if (Cmd->Name == Name)
+        return Cmd->Filler;
+  return {};
 }
 
 // Returns the index of the given section name in linker script
@@ -754,7 +755,7 @@
       return;
     }
     Tok = Tok.substr(3);
-    Opt.Filler[OutSec] = parseHex(Tok);
+    Cmd->Filler = parseHex(Tok);
     next();
   }
 }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D22615.64833.patch
Type: text/x-patch
Size: 1229 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160721/d7fd6c4e/attachment.bin>