[PATCH] D22611: [compiler-rt][XRay] re-submitting r276117, with fixes for build breakage due to extraneous and missing dependencies and attempts to build on unsupported OSes

Eric Christopher via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 21 00:40:15 PDT 2016


echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.

OK with one comment.

Thanks!

-eric


================
Comment at: lib/CMakeLists.txt:7
@@ -6,1 +6,3 @@
 
+# Hoist the building of sanitizer_common on whether we're building either the
+# sanitizers or xray (or both).
----------------
This definitely makes more sense, can you add a TODO to factor out the command line handling?


https://reviews.llvm.org/D22611





More information about the llvm-commits mailing list