[PATCH] D22611: [compiler-rt][XRay] re-submitting r276117, with fixes for build breakage due to extraneous and missing dependencies and attempts to build on unsupported OSes

[Eric Christopher via llvm-commits]

echristo added a comment.

One inline comment, otherwise I don't see any problems.

-eric


================
Comment at: lib/CMakeLists.txt:61-68
@@ +60,9 @@
+
+if(COMPILER_RT_BUILD_XRAY)
+  if(COMPILER_RT_HAS_XRAY AND COMPILER_RT_HAS_SANITIZER_COMMON)
+		if (NOT COMPILER_RT_BUILD_SANITIZERS)
+      add_subdirectory(sanitizer_common)
+		endif()
+    add_subdirectory(xray)
+  endif()
+endif()
----------------
This looks unnecessarily complicated?


https://reviews.llvm.org/D22611