[PATCH] D22604: [ELF] - Initial support of tree-style linker script implemented.

[George Rimar via llvm-commits]

grimar added inline comments.

================
Comment at: ELF/LinkerScript.cpp:44
@@ +43,3 @@
+  return C->Kind == AssignmentKind;
+};
+
----------------
Eugene.Zelenko wrote:
> Please fix -Wextra-semi.
Will do, thanks.

================
Comment at: ELF/LinkerScript.h:56
@@ +55,3 @@
+  BaseCommand(int K) : Kind(K) {}
+  int Kind;
+};
----------------
ruiu wrote:
> I think you need to define a virtual destructor because you are destructing derived classes instances through base class pointers.
Right, thanks ! And thank you so much for reviewing and help with that !


https://reviews.llvm.org/D22604