[PATCH] D22612: [compiler-rt] Disable some unittests on windows that rely on shell command

[Etienne Bergeron via llvm-commits]

etienneb created this revision.
etienneb added a reviewer: rnk.
etienneb added subscribers: chrisha, wang0109, llvm-commits.
Herald added subscribers: kubabrecka, srhines, danalbert, tberghammer.

These unittests are not running on windows because they are using incorrect commands.
They were not failing on 32-bits because there is a requirement: asan-64-bits.

```
$ "nm" "C:\src\llvm\ninja64\projects\compiler-rt\test\asan\X86_64WindowsConfig\TestCases\Output\no_asan_gen_globals.c.tmp.exe"
# command stderr:
'nm': command not found
error: command failed with exit status: 127
```

```
$ "rm" "-rf" "C:\src\llvm\ninja64\projects\compiler-rt\test\asan\X86_64WindowsConfig\TestCases\Output/coverage-tracing"
$ "mkdir" "C:\src\llvm\ninja64\projects\compiler-rt\test\asan\X86_64WindowsConfig\TestCases\Output/coverage-tracing"
$ "A=x"
# command stderr:
'A=x': command not found
error: command failed with exit status: 127
```


```
$ "DIR=C:\src\llvm\ninja64\projects\compiler-rt\test\asan\X86_64WindowsConfig\TestCases\Output/coverage-order-pcs"
# command stderr:
'DIR=C:\\src\\llvm\\ninja64\\projects\\compiler-rt\\test\\asan\\X86_64WindowsConfig\\TestCases\\Output/coverage-order-pcs': command not found
error: command failed with exit status: 127
```

https://reviews.llvm.org/D22612

Files:
  lib/asan/asan_interceptors.cc
  test/asan/TestCases/coverage-order-pcs.cc
  test/asan/TestCases/coverage-tracing.cc
  test/asan/TestCases/no_asan_gen_globals.c

Index: test/asan/TestCases/no_asan_gen_globals.c
===================================================================
--- test/asan/TestCases/no_asan_gen_globals.c
+++ test/asan/TestCases/no_asan_gen_globals.c
@@ -2,7 +2,7 @@
 // XFAIL: android
 // FIXME: http://llvm.org/bugs/show_bug.cgi?id=22682
 // REQUIRES: asan-64-bits
-//
+// UNSUPPORTED: win32
 // Make sure __asan_gen_* strings do not end up in the symbol table.
 
 // RUN: %clang_asan %s -o %t.exe
Index: test/asan/TestCases/coverage-tracing.cc
===================================================================
--- test/asan/TestCases/coverage-tracing.cc
+++ test/asan/TestCases/coverage-tracing.cc
@@ -25,7 +25,7 @@
 // RUN: rm -rf   %T/coverage-tracing
 //
 // REQUIRES: asan-64-bits
-// UNSUPPORTED: android
+// UNSUPPORTED: android, win32
 
 #include <stdlib.h>
 volatile int sink;
Index: test/asan/TestCases/coverage-order-pcs.cc
===================================================================
--- test/asan/TestCases/coverage-order-pcs.cc
+++ test/asan/TestCases/coverage-order-pcs.cc
@@ -20,7 +20,7 @@
 // RUN: rm -rf $DIR
 // Ordering works only in 64-bit mode for now.
 // REQUIRES: asan-64-bits
-// UNSUPPORTED: android
+// UNSUPPORTED: android, win32
 #include <stdio.h>
 
 void foo() { fprintf(stderr, "FOO\n"); }
Index: lib/asan/asan_interceptors.cc
===================================================================
--- lib/asan/asan_interceptors.cc
+++ lib/asan/asan_interceptors.cc
@@ -399,7 +399,7 @@
     }                                                                          \
     ENSURE_ASAN_INITED();                                                      \
     if (flags()->replace_intrin) {                                             \
-      if (to != from) {                                                        \
+      if (PLATFORM_HAS_DIFFERENT_MEMCPY_AND_MEMMOVE && to != from) {           \
         CHECK_RANGES_OVERLAP("memcpy", to, size, from, size);                  \
       }                                                                        \
       ASAN_READ_RANGE(ctx, from, size);                                        \


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D22612.64822.patch
Type: text/x-patch
Size: 2141 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160721/f34c6ec6/attachment.bin>