[PATCH] D22491: Added ThinLTO inlining statistics

Piotr Padlewski via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 20 22:02:30 PDT 2016


Prazek added inline comments.

================
Comment at: lib/Transforms/IPO/InlinerStats.cpp:24
@@ +23,3 @@
+    // basically small optimization to not put this into graph, so for modules
+    // without imported functions there won't be any graph traversal.
+    CalleeNode.NumberOfRealInlines++;
----------------
tejohnson wrote:
> Even with imported functions, by not putting intra-module inlines in the graph it should reduce the size and the traversal overhead. Although I would expect that most intra module inlines would have been done already in the compile step. Maybe just note that in your comment.
yea, but if you just pass those flags to see the statistics for non thinlto then it is useless to compute it by graph. I gonnna mention it.


https://reviews.llvm.org/D22491





More information about the llvm-commits mailing list