[PATCH] D22603: [coroutines] Part 1 of N: Documentation

[David Majnemer via llvm-commits]

majnemer added a subscriber: majnemer.
majnemer added a comment.

Out of curiosity, what lead you to use tokens for `coro.save` and `coro.suspend`?


================
Comment at: docs/Coroutines.rst:658
@@ +657,3 @@
+
+      declare <type>* @llvm.coro.promise.p0<type>(i8* <handle>)
+
----------------
Why not return i8* ?  Bitcasting the i8* seems nicer unless we expect the result to be in another LLVM address space.

================
Comment at: docs/Coroutines.rst:718-719
@@ +717,4 @@
+
+    declare i32 @llvm.coro.size()
+    declare i64 @llvm.coro.size()
+
----------------
Shouldn't this be llvm.coro.size.i32 and llvm.coro.size.i64?

================
Comment at: docs/Coroutines.rst:908
@@ +907,3 @@
+
+  declare void @llvm.coro.end(i8* hdl, i1 unwind)
+
----------------
In other places, you call this <handle>.  I'd recommend you make the two variants agree.


https://reviews.llvm.org/D22603