[PATCH] D21449: Target independent codesize heuristics for Loop Idiom Recognition

[Sunita_Marathe via llvm-commits]

Sunita_Marathe updated this revision to Diff 64780.
Sunita_Marathe added a comment.

> We need more strict checks here? My guess is this test will pass both before and after this change. You need to account for the hoisting of the memset ...


Thank you I agree, and have modified the lit test for "You need to account for the hoisting of the memset".

However I am not sure of the need for "and possibly the length of the memset." since the loop memset merging is done by existing functionality which is not part of the current change set.

Thanks,
Sunita


https://reviews.llvm.org/D21449

Files:
  lib/Transforms/Scalar/LoopIdiomRecognize.cpp
  test/Transforms/LoopIdiom/lir-heurs-multi-block-loop.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D21449.64780.patch
Type: text/x-patch
Size: 10109 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160720/b854be2b/attachment.bin>