[PATCH] D22586: [compiler-rt] Fix broken SymInitialize unittest
Etienne Bergeron via llvm-commits
llvm-commits at lists.llvm.org
Wed Jul 20 14:17:18 PDT 2016
etienneb marked an inline comment as done.
================
Comment at: test/asan/TestCases/Windows/report_after_syminitialize.cc:12
@@ -11,3 +11,3 @@
// Make sure the RTL recovers from "fInvadeProcess=FALSE".
if (!SymInitialize(GetCurrentProcess(), 0, FALSE))
return 42;
----------------
rnk wrote:
> Doesn't this fail, though?
No, it's not.
Nothing got called before we reach line 15 (write to invalid location).
Than, the report function is calling the initialized function to load dbghelp.
So, it's not affecting this test.
https://reviews.llvm.org/D22586
More information about the llvm-commits
mailing list