[lld] r275162 - [ELF] - Make few members of Writer to be global and export them for reuse

Chandler Carruth via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 20 11:55:31 PDT 2016


On Tue, Jul 12, 2016 at 1:58 AM George Rimar via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> Author: grimar
> Date: Tue Jul 12 03:50:42 2016
> New Revision: 275162
>
> URL: http://llvm.org/viewvc/llvm-project?rev=275162&view=rev
> Log:
> [ELF] - Make few members of Writer to be global and export them for reuse
>
> Creating sections on linkerscript side requires some methods
> that can be reused if are exported from writer.
>
> Patch implements that change.
>
> Differential revision: http://reviews.llvm.org/D20104


Please be very careful in the future when putting templates into a header
file and not their definitions....


> +
> +template <class ELFT>
> +llvm::StringRef getOutputSectionName(InputSectionBase<ELFT> *S);
>

There were no explicit template instantiations for this function, they had
to be added in r276133 to fix a build bot that was broken for days. Sadly,
this in turn exposed...


> +
> +template <class ELFT>
> +void reportDiscarded(InputSectionBase<ELFT> *IS,
> +                     const std::unique_ptr<elf::ObjectFile<ELFT>> &File);
>

Which also had no explicit instantiations, which I just fixed in r276155....
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160720/d6c3ac9a/attachment.html>


More information about the llvm-commits mailing list