[PATCH] D22037: [RFC] Refactoring release docs

Renato Golin via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 20 10:07:59 PDT 2016


rengolin added inline comments.

================
Comment at: RELEASE_TESTERS.TXT:2
@@ +1,3 @@
+This file is a list of the people responsible for ensuring that targets and
+environments get tested and validated during the upstream release process.
+They will also, in conjunction with the release manager and the code owners,
----------------
hans wrote:
> I don't think "upstream" makes sense when referring to ourselves.
ok

================
Comment at: RELEASE_TESTERS.TXT:41
@@ +40,3 @@
+T: x86
+O: Darwin, Windows
+
----------------
hans wrote:
> Can you drop Darwin from my entry? I'll still build and test it if no one else does, but it would be great if we could find someone to sign up for it.
ok

================
Comment at: RELEASE_TESTERS.TXT:53-56
@@ +52,5 @@
+
+N: Daniel Sanders
+E: daniel.sanders at imgtec.com
+T: MIPS
+O: Linux
----------------
dsanders wrote:
> Vasileios Kalintiris will be taking over my release testing starting with this release.
> 
> I also upload a x86_64 tarball for Debian at the moment because it's a by-product of some of my MIPS testing.
done

================
Comment at: docs/HowToReleaseLLVM.rst:91
@@ -94,3 +90,3 @@
    ``release_XY``, where ``X`` is the major and ``Y`` the minor release
    numbers.  The branches should be created using the following commands:
 
----------------
hans wrote:
> The branches are actually created by the utils/release/tag.sh script. I'd suggest removing the commands below.
ok

================
Comment at: docs/HowToReleaseLLVM.rst:169
@@ +168,3 @@
+
+The minimum versions of the tools to compile ``llvm`` and ``clang`` are:
+
----------------
hans wrote:
> Isn't this already documented somewhere else? I worry that this will get out-dated, as the previous text was.
added a link instead.


https://reviews.llvm.org/D22037





More information about the llvm-commits mailing list