[PATCH] D22574: [ELF] - Refactor of LinkerScript<ELFT>::getPhdrIndicesForSection

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 20 09:42:23 PDT 2016


ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM


================
Comment at: ELF/LinkerScript.cpp:461
@@ -461,3 +460,3 @@
           Opt.PhdrsCommands.rbegin(), Opt.PhdrsCommands.rend(),
           [PhdrName](PhdrsCommand &Cmd) { return Cmd.Name == PhdrName; });
       if (ItPhdr == Opt.PhdrsCommands.rend())
----------------
Please replace `[PhdrName]` with `[&]` as the function body is so short.


https://reviews.llvm.org/D22574





More information about the llvm-commits mailing list