[PATCH] D22564: [ELF] Support FLAGS attribute in PHDR definition

[Rui Ueyama via llvm-commits]

ruiu added inline comments.

================
Comment at: ELF/LinkerScript.cpp:620
@@ -618,3 +619,3 @@
     StringRef Tok = next();
-    Opt.PhdrsCommands.push_back({Tok, PT_NULL, false, false});
+    Opt.PhdrsCommands.push_back({Tok, PT_NULL, false, false, false, 0});
     PhdrsCommand &PhdrCmd = Opt.PhdrsCommands.back();
----------------
evgeny777 wrote:
> ruiu wrote:
> > Set Flags to PF_R by default. Then you should be able to remove HasFlags member.
> I have small concern about such change. Currently if we don't set PHDR flags in script then flags are OR-combined from member section flags. If we set flags in script then I guess we can't change them while assigning sections to segment, can we?
I see. Then how about setting to -1 if a flag is absent?


Repository:
  rL LLVM

https://reviews.llvm.org/D22564