[PATCH] D19976: [ELF] - Prototype of possible linkerscript redesign.

[Eugene Leviant via llvm-commits]

evgeny777 added a comment.

Is it any different from https://reviews.llvm.org/D22455 after your changes?


================
Comment at: ELF/LinkerScript.cpp:224
@@ +223,3 @@
+    OutputSectionFactory<ELFT> &Factory, SymbolTable<ELFT> &Symtab,
+    std::vector<OutputSectionBase<ELFT> *> &OutList, size_t Ndx) {
+  std::vector<uint8_t> *Filler = nullptr;
----------------
You don't need to pass Symtab. You can just use Symtab<ELFT>::X

================
Comment at: ELF/LinkerScript.cpp:256
@@ +255,3 @@
+                                   SymbolTable<ELFT> &Symtab) {
+  std::vector<OutputSectionBase<ELFT> *> Sections;
+  for (size_t I = 0, E = Opt.Commands.size(); I != E; ++I)
----------------
Ditto.

================
Comment at: ELF/LinkerScript.cpp:269
@@ -223,1 +268,3 @@
+      if (!isDiscarded(C) && !C->OutSec)
+        addSection(Factory, getOutputSectionName(C), C, Sections);
 
----------------
I have strong guess, that Rui will ask you to use lambda instead of addSection :)


https://reviews.llvm.org/D19976