[PATCH] D21612: [compiler-rt] [XRay] Basic initialization and flag definition for XRay runtime

[Reid Kleckner via llvm-commits]

rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

Thanks for messing around with the asm parts, it's a pain. lgtm with nits


================
Comment at: lib/xray/xray_trampoline_x86.S:27
@@ +26,3 @@
+	.cfi_def_cfa_offset 16
+	subq $72, %rsp
+	movq	%rdi, 64(%rsp)
----------------
This is the unwind info you should have after the sub:
  .cfi_def_cfa_offset 88
  .cfi_offset %rbp, -16

================
Comment at: lib/xray/xray_trampoline_x86.S:43-44
@@ +42,4 @@
+	// assume that %r10d has the function id.
+	movl	%r10d, 4(%rsp)
+	movl	4(%rsp), %edi
+	xor	%esi,%esi
----------------
Can this be `movl %r10d, %edi`? The spill seems unnecessary.


https://reviews.llvm.org/D21612