[compiler-rt] r276112 - tsan: fix windows build

Dmitry Vyukov via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 20 05:50:50 PDT 2016


Author: dvyukov
Date: Wed Jul 20 07:50:49 2016
New Revision: 276112

URL: http://llvm.org/viewvc/llvm-project?rev=276112&view=rev
Log:
tsan: fix windows build

It's only asan that installs vectored SEH handler to map memory lazily.


Modified:
    compiler-rt/trunk/lib/sanitizer_common/sanitizer_win.cc

Modified: compiler-rt/trunk/lib/sanitizer_common/sanitizer_win.cc
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_win.cc?rev=276112&r1=276111&r2=276112&view=diff
==============================================================================
--- compiler-rt/trunk/lib/sanitizer_common/sanitizer_win.cc (original)
+++ compiler-rt/trunk/lib/sanitizer_common/sanitizer_win.cc Wed Jul 20 07:50:49 2016
@@ -173,10 +173,10 @@ void *MmapFixedNoReserve(uptr fixed_addr
   // FIXME: is this really "NoReserve"? On Win32 this does not matter much,
   // but on Win64 it does.
   (void)name;  // unsupported
-#if SANITIZER_WINDOWS64
-  // On Windows64, use MEM_COMMIT would result in error
+#if !SANITIZER_GO && SANITIZER_WINDOWS64
+  // On asan/Windows64, use MEM_COMMIT would result in error
   // 1455:ERROR_COMMITMENT_LIMIT.
-  // We use exception handler to commit page on demand.
+  // Asan uses exception handler to commit page on demand.
   void *p = VirtualAlloc((LPVOID)fixed_addr, size, MEM_RESERVE, PAGE_READWRITE);
 #else
   void *p = VirtualAlloc((LPVOID)fixed_addr, size, MEM_RESERVE | MEM_COMMIT,




More information about the llvm-commits mailing list