[PATCH] D22561: [InstCombine] Provide more test cases for cast-folding [NFC]

Matthias J. Reisinger via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 20 02:29:38 PDT 2016


mreisinger created this revision.
mreisinger added a reviewer: grosser.
mreisinger added a subscriber: llvm-commits.

In r275989 we enabled the folding of `logic(cast(icmp), cast(icmp))` to `cast(logic(icmp, icmp))`. Here we add more test cases to assure this folding works for all of logical operations `and`/`or`/`xor`.

https://reviews.llvm.org/D22561

Files:
  test/Transforms/InstCombine/zext.ll

Index: test/Transforms/InstCombine/zext.ll
===================================================================
--- test/Transforms/InstCombine/zext.ll
+++ test/Transforms/InstCombine/zext.ll
@@ -73,22 +73,54 @@
   ret <2 x i64> %zext2
 }
 
-; Assert that zexts in logic(zext(icmp), zext(icmp)) can be folded
-; CHECK-LABEL: @fold_logic_zext_icmp(
+; Assert that zexts in and(zext(icmp), zext(icmp)) can be folded
+; CHECK-LABEL: @fold_and_zext_icmp(
 ; CHECK-NEXT:    [[ICMP1:%.*]] = icmp sgt i64 %a, %b
 ; CHECK-NEXT:    [[ICMP2:%.*]] = icmp slt i64 %a, %c
 ; CHECK-NEXT:    [[AND:%.*]] = and i1 [[ICMP1]], [[ICMP2]]
 ; CHECK-NEXT:    [[ZEXT:%.*]] = zext i1 [[AND]] to i8
 ; CHECK-NEXT:    ret i8 [[ZEXT]]
-define i8 @fold_logic_zext_icmp(i64 %a, i64 %b, i64 %c) {
+define i8 @fold_and_zext_icmp(i64 %a, i64 %b, i64 %c) {
   %1 = icmp sgt i64 %a, %b
   %2 = zext i1 %1 to i8
   %3 = icmp slt i64 %a, %c
   %4 = zext i1 %3 to i8
   %5 = and i8 %2, %4
   ret i8 %5
 }
 
+; Assert that zexts in or(zext(icmp), zext(icmp)) can be folded
+; CHECK-LABEL: @fold_or_zext_icmp(
+; CHECK-NEXT:    [[ICMP1:%.*]] = icmp sgt i64 %a, %b
+; CHECK-NEXT:    [[ICMP2:%.*]] = icmp slt i64 %a, %c
+; CHECK-NEXT:    [[OR:%.*]] = or i1 [[ICMP1]], [[ICMP2]]
+; CHECK-NEXT:    [[ZEXT:%.*]] = zext i1 [[OR]] to i8
+; CHECK-NEXT:    ret i8 [[ZEXT]]
+define i8 @fold_or_zext_icmp(i64 %a, i64 %b, i64 %c) {
+  %1 = icmp sgt i64 %a, %b
+  %2 = zext i1 %1 to i8
+  %3 = icmp slt i64 %a, %c
+  %4 = zext i1 %3 to i8
+  %5 = or i8 %2, %4
+  ret i8 %5
+}
+
+; Assert that zexts in xor(zext(icmp), zext(icmp)) can be folded
+; CHECK-LABEL: @fold_xor_zext_icmp(
+; CHECK-NEXT:    [[ICMP1:%.*]] = icmp sgt i64 %a, %b
+; CHECK-NEXT:    [[ICMP2:%.*]] = icmp slt i64 %a, %c
+; CHECK-NEXT:    [[XOR:%.*]] = xor i1 [[ICMP1]], [[ICMP2]]
+; CHECK-NEXT:    [[ZEXT:%.*]] = zext i1 [[XOR]] to i8
+; CHECK-NEXT:    ret i8 [[ZEXT]]
+define i8 @fold_xor_zext_icmp(i64 %a, i64 %b, i64 %c) {
+  %1 = icmp sgt i64 %a, %b
+  %2 = zext i1 %1 to i8
+  %3 = icmp slt i64 %a, %c
+  %4 = zext i1 %3 to i8
+  %5 = xor i8 %2, %4
+  ret i8 %5
+}
+
 ; Assert that zexts in logic(zext(icmp), zext(icmp)) are also folded accross
 ; nested logical operators.
 ; CHECK-LABEL: @fold_nested_logic_zext_icmp(


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D22561.64648.patch
Type: text/x-patch
Size: 2241 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160720/c59dd95b/attachment.bin>


More information about the llvm-commits mailing list