[PATCH] D22521: [MBP] do not reorder and move up loop latch block
Sjoerd Meijer via llvm-commits
llvm-commits at lists.llvm.org
Wed Jul 20 01:19:58 PDT 2016
SjoerdMeijer added inline comments.
================
Comment at: lib/CodeGen/MachineBlockPlacement.cpp:1112
@@ -1070,2 +1111,3 @@
return nullptr;
+ }
----------------
mgrang wrote:
> Can we change the two ifs into an if-else clause and move the "return nullptr" outside the if-else? (and also get rid of the braces after the ifs). This will make the code more compact and reduce duplication.
I don't see how I can do this with an if-else and keep the different debug messages. I created these 2 different ifs because I wanted to see the exact reason for not selecting a new header.
https://reviews.llvm.org/D22521
More information about the llvm-commits
mailing list