[PATCH] D22535: [LSV] Don't assume that loads/stores appear in address order in the BB.

Justin Lebar via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 19 17:58:46 PDT 2016


jlebar added inline comments.

================
Comment at: lib/Transforms/Vectorize/LoadStoreVectorizer.cpp:455
@@ -451,1 +454,3 @@
+    unsigned ChainInstrLoc = ChainInstrs[ChainInstrIdx].second;
+    bool OK = true;
     for (auto EntryMem : MemoryInstrs) {
----------------
asbirlea wrote:
> Nit: %s/OK/No[Interfering]Alias[Found]
> Better yet, reverse the condition to AliasFound = false; and check below 
> ```
> if(AliasFound) ...
> ```
Much better, thanks.


https://reviews.llvm.org/D22535





More information about the llvm-commits mailing list