[PATCH] D22368: Replace hot-callsite based heuristic to use its own threshold parameter instead of share inline-hint parameter

[Easwaran Raman via llvm-commits]

eraman added inline comments.

================
Comment at: lib/Analysis/InlineCost.cpp:69
@@ -68,1 +68,3 @@
 
+static cl::opt<int>
+    HotCallSiteThreshold("hot-callsite-threshold", cl::Hidden, cl::init(3000),
----------------
Adding a threshold different from inlinehint-threshold makes sense. But if you want to set the default this high, then it is important to have numbers to justify. Running spec with different thresholds and a comment here saying you chose this default because this gives the best performance/size tradeoff is important.


https://reviews.llvm.org/D22368