[PATCH] D22532: [LSV] Nix two global (ish) variables in the LoadStoreVectorizer. NFC
Justin Lebar via llvm-commits
llvm-commits at lists.llvm.org
Tue Jul 19 16:26:44 PDT 2016
This revision was automatically updated to reflect the committed changes.
Closed by commit rL276054: [LSV] Nix two global (ish) variables in the LoadStoreVectorizer. NFC (authored by jlebar).
Changed prior to commit:
https://reviews.llvm.org/D22532?vs=64561&id=64601#toc
Repository:
rL LLVM
https://reviews.llvm.org/D22532
Files:
llvm/trunk/lib/Transforms/Vectorize/LoadStoreVectorizer.cpp
Index: llvm/trunk/lib/Transforms/Vectorize/LoadStoreVectorizer.cpp
===================================================================
--- llvm/trunk/lib/Transforms/Vectorize/LoadStoreVectorizer.cpp
+++ llvm/trunk/lib/Transforms/Vectorize/LoadStoreVectorizer.cpp
@@ -43,19 +43,17 @@
// TODO: Remove this
static const unsigned TargetBaseAlign = 4;
-class Vectorizer {
- typedef SmallVector<Value *, 8> ValueList;
- typedef MapVector<Value *, ValueList> ValueListMap;
+typedef SmallVector<Value *, 8> ValueList;
+typedef MapVector<Value *, ValueList> ValueListMap;
+class Vectorizer {
Function &F;
AliasAnalysis &AA;
DominatorTree &DT;
ScalarEvolution &SE;
TargetTransformInfo &TTI;
const DataLayout &DL;
IRBuilder<> Builder;
- ValueListMap StoreRefs;
- ValueListMap LoadRefs;
public:
Vectorizer(Function &F, AliasAnalysis &AA, DominatorTree &DT,
@@ -115,7 +113,7 @@
BasicBlock::iterator To);
/// Collects load and store instructions to vectorize.
- void collectInstructions(BasicBlock *BB);
+ std::pair<ValueListMap, ValueListMap> collectInstructions(BasicBlock *BB);
/// Processes the collected instructions, the \p Map. The elements of \p Map
/// should be all loads or all stores.
@@ -198,7 +196,8 @@
// Scan the blocks in the function in post order.
for (BasicBlock *BB : post_order(&F)) {
- collectInstructions(BB);
+ ValueListMap LoadRefs, StoreRefs;
+ std::tie(LoadRefs, StoreRefs) = collectInstructions(BB);
Changed |= vectorizeChains(LoadRefs);
Changed |= vectorizeChains(StoreRefs);
}
@@ -493,9 +492,10 @@
return Chain.size();
}
-void Vectorizer::collectInstructions(BasicBlock *BB) {
- LoadRefs.clear();
- StoreRefs.clear();
+std::pair<ValueListMap, ValueListMap>
+Vectorizer::collectInstructions(BasicBlock *BB) {
+ ValueListMap LoadRefs;
+ ValueListMap StoreRefs;
for (Instruction &I : *BB) {
if (!I.mayReadOrWriteMemory())
@@ -569,6 +569,8 @@
StoreRefs[ObjPtr].push_back(SI);
}
}
+
+ return {LoadRefs, StoreRefs};
}
bool Vectorizer::vectorizeChains(ValueListMap &Map) {
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D22532.64601.patch
Type: text/x-patch
Size: 2145 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160719/5fd1a23f/attachment.bin>
More information about the llvm-commits
mailing list