[PATCH] D22534: [LSV] Insert stores at the right point.

Justin Lebar via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 19 14:18:25 PDT 2016


jlebar created this revision.
jlebar added a reviewer: asbirlea.
jlebar added subscribers: llvm-commits, arsenm.
Herald added a reviewer: tstellarAMD.
Herald added a subscriber: mzolotukhin.

Previously, the insertion point for stores was the last instruction in
Chain *before calling getVectorizablePrefixEndIdx*.  Thus if
getVectorizablePrefixEndIdx didn't return Chain.size(), we still would
insert at the last instruction in Chain.

This patch changes our internal API a bit in an attempt to make it less
prone to this sort of error.  As a result, we end up recalculating the
Chain's boundary instructions, but I think worrying about the speed hit
of this is a premature optimization right now.

https://reviews.llvm.org/D22534

Files:
  lib/Transforms/Vectorize/LoadStoreVectorizer.cpp
  test/Transforms/LoadStoreVectorizer/AMDGPU/insertion-point.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D22534.64563.patch
Type: text/x-patch
Size: 7150 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160719/3b52509b/attachment.bin>


More information about the llvm-commits mailing list