[PATCH] D22403: FileCheck Enhancement - pattern templates.

[Adrian Prantl via llvm-commits]

aprantl added a comment.

A couple of general remarks about the proposed syntax:

Using CHECK-lines to define meta-variables without checking anything diverges from FileCheck's usual behavior. I find the name CHECK-PATTERN (I know that CHECK can be renamed, but still) particularly misleading and confusing. I would expect something more like CHECK-DEFINE-PATTERN or even passing the patterns to FileCheck on the command line instead.

The syntax of \#, #:, \= is different from what we usually have in FileCheck where we usually use double-brackets "[[" to escape. Why is it so different? Is this borrowed from some other language that users can be expected to have some familiarity with?


================
Comment at: docs/CommandGuide/FileCheck.rst:529
@@ +528,3 @@
+
+    // CHECK :  INC  \#( reg_hex_num)\:(regName)\=(reg)
+
----------------
I don't understand this example. Is it really equivalent to the next example as claimed in the text, or does it have side-effects? If so, what are the side-effects?


https://reviews.llvm.org/D22403