[PATCH] D22448: [AArch64] Cache line size and PredictableSelectIsExpensive for Vulcan

[pankaj gode via llvm-commits]

pgode added inline comments.

================
Comment at: lib/Target/AArch64/AArch64Subtarget.cpp:78
@@ -77,2 +77,3 @@
   case Vulcan:
+    CacheLineSize = 64;
     MaxInterleaveFactor = 4;
----------------
flyingforyou wrote:
> `CacheLineSize` is only used for `LoopDataPrefetch`. Is there any reason that you define this vaule only?
> 
> Without defining `PrefetchDistance`, `MinPrefetchStride`, `MaxPrefetchIterationsAhead`, it's not worth it right now.
I agree that apart from CacheLineSize, we need the other parameters for LoopDataPrefetch to be effective.  
We are still working on defining other values. So I think, I better ignore this change from the patch & submit it as separate patch when I have other parameters as well.

The 2nd change i.e.PredictableSelectIsExpensive, still hold true for Vulcan. So, I am updating the diff.
Please suggest, if this change is fine.


https://reviews.llvm.org/D22448