[PATCH] D21785: [RFC]Add unittests to {ARM | AArch64}TargetParser

Renato Golin via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 19 06:35:38 PDT 2016


rengolin added inline comments.

================
Comment at: lib/Support/TargetParser.cpp:455
@@ -454,2 +454,3 @@
                                      std::vector<const char *> &Features) {
-  if (ArchKind == ARM::AK_INVALID || ArchKind >= ARM::AK_LAST)
+  if (ArchKind == static_cast<unsigned>(AArch64::ArchKind::AK_INVALID) ||
+      ArchKind >= static_cast<unsigned>(AArch64::ArchKind::AK_LAST))
----------------
Now I see why you wanted a different enum.

@compnerd, I really don't mind either way, so I'll leave it up to you. :)


https://reviews.llvm.org/D21785





More information about the llvm-commits mailing list