[PATCH] Fix PR28575.

Rafael EspĂ­ndola via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 19 05:16:47 PDT 2016


> I think you want to remove "That means ..." part because it doesn't describe the behavior of this function.

Done.

> Why don't you store relocation indices to section pieces? It would be better than having parallel arrays.

The common use is for SHF_MERGE sections that don't have relocations.
The existing code is trying to pack it to be cache friendly (uses
bitfield).

I could just remove SplitInputSection and have MergeInputSection and
EhInputSection declare their own Pieces array. The one in
EhInputSection would have the first relocation of each piece. What do
you think?

> Please write a function comment why you needed this function (e.g. why .eh_frame needs special treament).

Done.

New patch attached.

Cheers,
Rafael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fix-PR28575.patch
Type: text/x-patch
Size: 12833 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160719/685b78e0/attachment.bin>


More information about the llvm-commits mailing list