[PATCH] D21808: [WebAssembly] Handle debug information and virtual registers without crashing

[Dan Gohman via llvm-commits]

sunfish resigned from this revision.
sunfish removed a reviewer: sunfish.
sunfish added a comment.

The changes to WebAssembly-specific code here look fine to me.

Concerning the changes to lib/CodeGen/AsmPrinter/DbgValueHistoryCalculator.cpp, I don't have a clear picture of how virtual registers will be handled in debug info yet, so I'm not confident in reviewing changes to target-independent code myself.

That said, for present purposes it may be sufficient to just make codegen not crash. That may be sufficient to motivate the patch, however if that's the case, I'd like to get it reviewed from someone who isn't also a WebAssembly developer, since this is changing code shared by all backends.


https://reviews.llvm.org/D21808