[llvm] r275822 - [Hexagon] Handle returning small structures by value

Krzysztof Parzyszek via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 18 10:30:41 PDT 2016


Author: kparzysz
Date: Mon Jul 18 12:30:41 2016
New Revision: 275822

URL: http://llvm.org/viewvc/llvm-project?rev=275822&view=rev
Log:
[Hexagon] Handle returning small structures by value

This is compliant with the official ABI, but allows experimentation with
calling conventions.

Added:
    llvm/trunk/test/CodeGen/Hexagon/ret-struct-by-val.ll
Modified:
    llvm/trunk/lib/Target/Hexagon/HexagonISelLowering.cpp

Modified: llvm/trunk/lib/Target/Hexagon/HexagonISelLowering.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Hexagon/HexagonISelLowering.cpp?rev=275822&r1=275821&r2=275822&view=diff
==============================================================================
--- llvm/trunk/lib/Target/Hexagon/HexagonISelLowering.cpp (original)
+++ llvm/trunk/lib/Target/Hexagon/HexagonISelLowering.cpp Mon Jul 18 12:30:41 2016
@@ -447,7 +447,13 @@ static bool RetCC_Hexagon32(unsigned Val
                             MVT LocVT, CCValAssign::LocInfo LocInfo,
                             ISD::ArgFlagsTy ArgFlags, CCState &State) {
   if (LocVT == MVT::i32 || LocVT == MVT::f32) {
-    if (unsigned Reg = State.AllocateReg(Hexagon::R0)) {
+    // Note that use of registers beyond R1 is not ABI compliant. However there
+    // are (experimental) IR passes which generate internal functions that
+    // return structs using these additional registers.
+    static const uint16_t RegList[] = { Hexagon::R0, Hexagon::R1,
+                                        Hexagon::R2, Hexagon::R3,
+                                        Hexagon::R4, Hexagon::R5};
+    if (unsigned Reg = State.AllocateReg(RegList)) {
       State.addLoc(CCValAssign::getReg(ValNo, ValVT, Reg, LocVT, LocInfo));
       return false;
     }

Added: llvm/trunk/test/CodeGen/Hexagon/ret-struct-by-val.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/Hexagon/ret-struct-by-val.ll?rev=275822&view=auto
==============================================================================
--- llvm/trunk/test/CodeGen/Hexagon/ret-struct-by-val.ll (added)
+++ llvm/trunk/test/CodeGen/Hexagon/ret-struct-by-val.ll Mon Jul 18 12:30:41 2016
@@ -0,0 +1,18 @@
+; RUN: llc -march=hexagon < %s | FileCheck %s
+; CHECK: r0 = add(r0, r1)
+
+; Allow simple structures to be returned by value.
+
+%s = type { i32, i32 }
+
+declare %s @foo() #0
+
+define i32 @fred() #0 {
+  %t0 = call %s @foo()
+  %x = extractvalue %s %t0, 0
+  %y = extractvalue %s %t0, 1
+  %r = add i32 %x, %y
+  ret i32 %r
+}
+
+attributes #0 = { nounwind }




More information about the llvm-commits mailing list