[PATCH] D22455: [ELF] Create output sections in LinkerScript class

[George Rimar via llvm-commits]

grimar added inline comments.

================
Comment at: ELF/LinkerScript.cpp:199
@@ -197,3 +198,3 @@
 bool LinkerScript<ELFT>::isDiscarded(InputSectionBase<ELFT> *S) {
-  return getOutputSection(S) == "/DISCARD/";
+  return !S || !S->Live || S->OutSec || getOutputSection(S) == "/DISCARD/";
 }
----------------
evgeny777 wrote:
> grimar wrote:
> > This method seems to be a almost copy of elf::isDiscarded(). Do you really need it then ?
> elf::isDiscarded no longer calls LinkerScript::isDiscarded and does not check S->OutSec.
> 
I know, but you probably can check that separatelly and keep the common logic.


Repository:
  rL LLVM

https://reviews.llvm.org/D22455