[llvm] r275141 - Mips: Avoid implicit iterator conversions, NFC

Daniel Sanders via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 18 01:43:44 PDT 2016


That explains why I'm not having any luck at reproducing this on my system :-).

Duncan: Sorry for the noise.

> -----Original Message-----
> From: Doug Gilmore
> Sent: 16 July 2016 00:51
> To: llvm-commits at lists.llvm.org
> Cc: dexonsmith at apple.com; Daniel Sanders
> Subject: RE: [llvm] r275141 - Mips: Avoid implicit iterator conversions, NFC
> 
> > The bisect is still running.
> 
> The bisect completed, the commit was CFE r275115:
> 
> http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-
> 20160711/164393.html
> 
> I'll note the issue on the CFE commits list.
> 
> Doug
> ________________________________________
> From: Doug Gilmore
> Sent: Friday, July 15, 2016 3:42 PM
> To: llvm-commits at lists.llvm.org
> Cc: dexonsmith at apple.com; Daniel Sanders
> Subject: RE: [llvm] r275141 - Mips: Avoid implicit iterator conversions, NFC
> 
> > From: Doug Gilmore
> > Sent: Friday, July 15, 2016 2:51 PM
> > To: llvm-commits at lists.llvm.org
> > Subject: Re: [llvm] r275141 - Mips: Avoid implicit iterator conversions, NFC
> >
> > [llvm] r275141 - Mips: Avoid implicit iterator conversions, NFC
> >
> > > Hmm.  Thanks for the revert and sorry for the trouble.
> > >
> > > Please send a reproduction so I can investigate (assuming you can
> > > confirm this is the cause).  Likely this is a surprise end iterator
> > > being dereferenced somehow (I saw some of those in other patches,
> > > but caught the problem locally in the lit tests).
> > Hello Duncan and Daniel,
> >
> > Whoops, I flubbed my (manual) bisect, r275141 is probably OK (I am in
> > the process of verifying that).
> Hi Duncan,
> 
> Your commit is OK:
> 
> https://dmz-
> portal.mips.com/bb/builders/LLVM%20with%20integrated%20assembler%20
> and%20fPIC%20and%20-O0/builds/803
> 
> So go ahead and recommit r275141 -- Thanks!
> >
> > I am in the process of running a real bisect to identify the bad
> > commit.
> The bisect is still running.
> 
> Doug
> >
> > I'll post an update soon.
> >
> > Sorry about that,
> >
> > Doug
> > >
> > > -- dpnes
> > >
> > > > On Jul 15, 2016, at 07:02, Daniel Sanders <Daniel.Sanders at
> imgtec.com> wrote:
> > > >
> > ...


More information about the llvm-commits mailing list