[PATCH] D21932: [ThinLTO] Perform profile-guided indirect call promotion

[Teresa Johnson via llvm-commits]

tejohnson added a comment.

In https://reviews.llvm.org/D21932#486256, @mehdi_amini wrote:

> LGTM with the two comments I made previously.


Thanks. Somehow I completely missed the last set of comments you added!


================
Comment at: lib/Analysis/ModuleSummaryAnalysis.cpp:97
@@ +96,3 @@
+          }
+        } else {
+          const CallInst *CI = dyn_cast<CallInst>(&I);
----------------
mehdi_amini wrote:
> Add a one line comment for this code block?
Will do.

================
Comment at: test/Transforms/PGOProfile/Inputs/thinlto_indirect_call_promotion.ll:3-4
@@ +2,4 @@
+target triple = "x86_64-unknown-linux-gnu"
+
+ at foo = common local_unnamed_addr global void ()* null, align 8
+
----------------
mehdi_amini wrote:
> I'm not sure why you need this definition?
You're right, this is unnecessary. Removed.


https://reviews.llvm.org/D21932