[PATCH] D12067: AMDGPU: Refactor exp instructions

Axel Davy via llvm-commits llvm-commits at lists.llvm.org
Sun Jul 17 00:03:10 PDT 2016


axeldavy added a comment.

In https://reviews.llvm.org/D12067#484345, @arsenm wrote:

> Update for trunk. Set mayLoad = 1 for EXP_DONE instead of hasSideEffects


Could you explain why ? To me it looks like hasSideEffects is the only way to guarantee the exp with the done bit is last.

Btw you forgot to update the comments in the part "Export opcodes" to reflect that change.


https://reviews.llvm.org/D12067





More information about the llvm-commits mailing list