[PATCH] D22433: Handle versioned symbols efficiently.

[Rui Ueyama via llvm-commits]

ruiu added inline comments.

================
Comment at: ELF/SymbolTable.cpp:598
@@ +597,3 @@
+    Len = std::max(Len, V.Name.size());
+  return Len;
+}
----------------
grimar wrote:
> I think return size_t would be more clean.
I agree, but it's a little bit tricky. At line 609, we are using the result to pass std::max. Since we want to compare the result of the expression against 0, we want to get a signed result. So I avoided using an unsigned value.


https://reviews.llvm.org/D22433