[PATCH] D22445: Avoid UB in maxIntN(64).

[Justin Lebar via llvm-commits]

jlebar updated this revision to Diff 64242.
jlebar marked an inline comment as done.
jlebar added a comment.

Simplify the expression.


https://reviews.llvm.org/D22445

Files:
  include/llvm/Support/MathExtras.h

Index: include/llvm/Support/MathExtras.h
===================================================================
--- include/llvm/Support/MathExtras.h
+++ include/llvm/Support/MathExtras.h
@@ -343,7 +343,9 @@
 inline int64_t maxIntN(int64_t N) {
   assert(N > 0 && N <= 64 && "integer width out of range");
 
-  return (INT64_C(1)<<(N-1)) - 1;
+  // This relies on two's complement wraparound when N == 64, so we convert to
+  // int64_t only at the very end to avoid UB.
+  return (UINT64_C(1) << (N - 1)) - 1;
 }
 
 /// isUIntN - Checks if an unsigned integer fits into the given (dynamic)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D22445.64242.patch
Type: text/x-patch
Size: 588 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160717/4570b5e6/attachment.bin>