[llvm] r275639 - [llvm-cov] Document a few private fields of CodeCoverageTool (NFC)

Vedant Kumar via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 15 15:44:54 PDT 2016


Author: vedantk
Date: Fri Jul 15 17:44:54 2016
New Revision: 275639

URL: http://llvm.org/viewvc/llvm-project?rev=275639&view=rev
Log:
[llvm-cov] Document a few private fields of CodeCoverageTool (NFC)

Modified:
    llvm/trunk/tools/llvm-cov/CodeCoverage.cpp
    llvm/trunk/tools/llvm-cov/CoverageViewOptions.h

Modified: llvm/trunk/tools/llvm-cov/CodeCoverage.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-cov/CodeCoverage.cpp?rev=275639&r1=275638&r2=275639&view=diff
==============================================================================
--- llvm/trunk/tools/llvm-cov/CodeCoverage.cpp (original)
+++ llvm/trunk/tools/llvm-cov/CodeCoverage.cpp Fri Jul 15 17:44:54 2016
@@ -101,11 +101,14 @@ public:
   std::string CoverageArch;
 
 private:
+  /// File paths (absolute, or otherwise) to input source files.
   std::vector<std::string> CollectedPaths;
 
+  /// Errors and warnings which have not been printed.
   std::mutex DeferredMessagesLock;
   std::vector<std::string> DeferredMessages;
 
+  /// A container for input source file buffers.
   std::mutex LoadedSourceFilesLock;
   std::vector<std::pair<std::string, std::unique_ptr<MemoryBuffer>>>
       LoadedSourceFiles;

Modified: llvm/trunk/tools/llvm-cov/CoverageViewOptions.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-cov/CoverageViewOptions.h?rev=275639&r1=275638&r2=275639&view=diff
==============================================================================
--- llvm/trunk/tools/llvm-cov/CoverageViewOptions.h (original)
+++ llvm/trunk/tools/llvm-cov/CoverageViewOptions.h Fri Jul 15 17:44:54 2016
@@ -40,7 +40,7 @@ struct CoverageViewOptions {
   }
 
   /// \brief Check if an output directory has been specified.
-  bool hasOutputDirectory() const { return ShowOutputDirectory != ""; }
+  bool hasOutputDirectory() const { return !ShowOutputDirectory.empty(); }
 };
 }
 




More information about the llvm-commits mailing list