[llvm] r275141 - Mips: Avoid implicit iterator conversions, NFC

Duncan Exon Smith via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 15 15:15:56 PDT 2016



> On Jul 15, 2016, at 14:57, Doug Gilmore <Doug.Gilmore at imgtec.com> wrote:
> 
> Forgot to add the both of you to the "To" list.
> 
> Doug
> ________________________________________
> From: Doug Gilmore
> Sent: Friday, July 15, 2016 2:51 PM
> To: llvm-commits at lists.llvm.org
> Subject: Re: [llvm] r275141 - Mips: Avoid implicit iterator conversions, NFC
> 
> [llvm] r275141 - Mips: Avoid implicit iterator conversions, NFC
> 
>> Hmm.  Thanks for the revert and sorry for the trouble.
>> 
>> Please send a reproduction so I can investigate (assuming you can
>> confirm this is the cause).  Likely this is a surprise end iterator
>> being dereferenced somehow (I saw some of those in other patches,
>> but caught the problem locally in the lit tests).
> Hello Duncan and Daniel,
> 
> Whoops, I flubbed my (manual) bisect, r275141 is probably OK (I am in
> the process of verifying that).

I'll wait to hear from you before I reapply the commit!

> 
> I am in the process of running a real bisect to identify the bad
> commit.
> 
> I'll post an update soon.
> 
> Sorry about that,
> 
> Doug
>> 
>> -- dpnes
>> 
>>> On Jul 15, 2016, at 07:02, Daniel Sanders <Daniel.Sanders at imgtec.com> wrote:
> ...


More information about the llvm-commits mailing list