[PATCH] D22373: [GlobalISel] Introduce a simple instruction selector.

Tom Stellard via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 15 13:52:13 PDT 2016


tstellarAMD added inline comments.

================
Comment at: lib/CodeGen/GlobalISel/InstructionSelect.cpp:61
@@ +60,3 @@
+         MII != End;) {
+      MachineInstr &MI = *MII++;
+      if (!ISel->select(MI))
----------------
tstellarAMD wrote:
> Won't this will fail if the target decides to delete the instruction?  I think targets should be allowed to delete the instruction, because updating MachineIntr in place is very tedious especially if you need to re-order the operands.
Nevermind, this looks OK.


https://reviews.llvm.org/D22373





More information about the llvm-commits mailing list