[PATCH] D21758: [X86] Accept SELECT op code for x86-64 fp128 type

Chih-Hung Hsieh via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 15 12:46:21 PDT 2016


chh added a comment.

I added test cases for non-MMX cases.
I think non-fp128 types should already be covered in other tests.
So far this patch is to fix the only problem I know with fp128 type on x86-64 targets with MMX.


================
Comment at: test/CodeGen/X86/fp128-select.ll:3
@@ +2,3 @@
+; RUN: llc < %s -O2 -mtriple=x86_64-linux-android -mattr=+mmx | FileCheck %s
+; RUN: llc < %s -O2 -mtriple=x86_64-linux-gnu -mattr=+mmx | FileCheck %s
+
----------------
RKSimon wrote:
> You shouldn't need to specify mmx here
The problem only happens on x86-64 targets that use 128 bits for long double and with mmx.
Now I added both mmx and non-mmx tests.




https://reviews.llvm.org/D21758





More information about the llvm-commits mailing list