[PATCH] D22399: [LoopDataPrefetch/AArch64] Don't add prefetch intrinsic, when the loop already has InlineAsm prefetch.

[Junmo Park via llvm-commits]

flyingforyou added inline comments.

================
Comment at: lib/Transforms/Scalar/LoopDataPrefetch.cpp:199
@@ +198,3 @@
+          // TODO: Need to check other architectures.
+          if (StringRef(IA->getAsmString()).startswith_lower("prfm"))
+            return MadeChange;
----------------
hfinkel wrote:
> I think this would need to be some kind of TTI callback; we don't want to embed this kind of logic here. Also, I assume you'd need to check all of the lines, not just the first one.
> I think this would need to be some kind of TTI callback; we don't want to embed this kind of logic here.

Sure, Could you recommend callback function name please?



> Also, I assume you'd need to check all of the lines, not just the first one.
Yes. I will change the StringRef's function to `find` from `startswith_lower`.



https://reviews.llvm.org/D22399