[PATCH] D20116: Add speculatable function attribute
Tom Stellard via llvm-commits
llvm-commits at lists.llvm.org
Thu Jul 14 19:30:13 PDT 2016
tstellarAMD added a comment.
In https://reviews.llvm.org/D20116#484877, @hfinkel wrote:
> In https://reviews.llvm.org/D20116#483719, @tstellarAMD wrote:
>
> > Rename the attribute to speculatable. This simplifies the patch a lot since
> > we are no longer trying to solve the problem where specifying one of
> > the memory properties for intrinsics implies that it has no side effects
> > (this should probably still be addressed in another patch).
> >
> > I wasn't sure exactly how to define the speculatable attribute
> > in the language ref, so I copied the definition from the
> > isSafeToSpeculativelyExecute() function.
>
>
> Makes sense to me. Is the idea to have isSafeToSpeculativelyExecute() return true on functions with this attribute?
Yes, this is the idea.
https://reviews.llvm.org/D20116
More information about the llvm-commits
mailing list