[PATCH] D22302: [ThinLTO/gold] Perform index-based weak/linkonce resolution

Piotr Padlewski via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 14 12:58:17 PDT 2016


Prazek added a subscriber: Prazek.

================
Comment at: tools/gold/gold-plugin.cpp:1018-1019
@@ +1017,4 @@
+    if (options::TheOutputType == options::OT_SAVE_TEMPS) {
+      // Always expect a provided filename in the ThinLTO backend.
+      assert(!SaveTempsFilename.empty());
+      SmallString<128> OptFilename(SaveTempsFilename);
----------------
I think it would be good to put this comment in an assert.


https://reviews.llvm.org/D22302





More information about the llvm-commits mailing list